Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Fix build image #12

Merged
merged 3 commits into from
Nov 21, 2024
Merged

Fix build image #12

merged 3 commits into from
Nov 21, 2024

Conversation

yonishelach
Copy link
Collaborator

  1. Fixed build image package versions.
  2. Updated Dockerfile
  3. Added node selector parameter to project_setup
  4. Removed private image name from notebook

@review-notebook-app Review Notebook App
Copy link

Check out this pull request on  ReviewNB

See visual diffs & provide feedback on Jupyter Notebooks.

Powered by ReviewNB

guy1992l
guy1992l requested changes Nov 20, 2024
View reviewed changes
Copy link
Member

@guy1992l guy1992l left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

The node selector should only be part of GPUs required functions.

guy1992l
guy1992l requested changes Nov 21, 2024
View reviewed changes
project_setup.py Outdated Show resolved Hide resolved
@yonishelach yonishelach merged commit f93d51a into mlrun:main Nov 21, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@guy1992l guy1992l guy1992l approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@yonishelach @guy1992l